Page 1 of 1

Octane 1.53.1 bug

Posted: Tue May 13, 2014 12:02 am
by MB
octane.render.start
{
renderTargetNode = rtNode,
maxSamples = nbSamples,
callback = renderCallback,
} it appear that, maxSample = nbSamples, no longer works, the maxsamples uses what ever is set on the render target instead of the value of nbSamples.

it works fine in v 1.52

best

mark

Re: Octane 1.53.1 bug

Posted: Tue May 13, 2014 12:09 am
by stratified
Hi Mark,

We removed that parameter from the API (see the release thread: http://render.otoy.com/forum/viewtopic.php?f=24&t=39746). We always use the value of the node that is connected to octane.P_MAX_SAMPLES in the kernel node.

cheers,
Thomas

Re: Octane 1.53.1 bug

Posted: Tue May 13, 2014 12:17 am
by MB
ok,

you just destroyed my ability to compose a movie in a fast preview mode and then run it later at the real sample rate, or is it fine to togle the render target, i liked the way it was.

best

Re: Octane 1.53.1 bug

Posted: Tue May 13, 2014 12:19 am
by MB
can u tell me more about how u intend this to new result thingy to be used?

Re: Octane 1.53.1 bug

Posted: Tue May 13, 2014 12:34 am
by abstrax
MB wrote:ok,

you just destroyed my ability to compose a movie in a fast preview mode and then run it later at the real sample rate, or is it fine to togle the render target, i liked the way it was.

best
But it didn't work if max samples in the kernel node was less than max samples of the render start call. So to make if fool-proof you had to set the max samples in the kernel anyway. And one less obvious problem of the old system: If you used a timeout as stop criteria and didn't specify the max samples, you had an implicit stop criteria of maxSamples=4000...

-> Just set the max samples in the kernel or set it to the maximum (256000) and use a timeout. All the other configurations etc. are done in the node system so there is no reason why max samples should be an exception.

Re: Octane 1.53.1 bug

Posted: Tue May 13, 2014 12:37 am
by MB
thx